Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting on macos #823

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Add linting on macos #823

merged 2 commits into from
Oct 14, 2024

Conversation

jerzywilczek
Copy link
Collaborator

Closes #822

@jerzywilczek jerzywilczek force-pushed the @jerzywilczek/macos-linting branch 7 times, most recently from 0ce09fa to 995d1a0 Compare October 14, 2024 14:27
@jerzywilczek jerzywilczek requested a review from brzep October 14, 2024 14:34
@jerzywilczek
Copy link
Collaborator Author

@wkozyra95 please review this even after the marge, I'm merging this now, bc we're not compiling on macos

@jerzywilczek jerzywilczek force-pushed the @jerzywilczek/macos-linting branch from 995d1a0 to ef12d0d Compare October 14, 2024 14:44
@jerzywilczek jerzywilczek merged commit d189e80 into master Oct 14, 2024
4 checks passed
@jerzywilczek jerzywilczek deleted the @jerzywilczek/macos-linting branch October 14, 2024 15:03
Copy link
Member

@wkozyra95 wkozyra95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run linting in CI on macos
3 participants